Skip to content

[7.x] Prettier v2.2 #84070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[7.x] Prettier v2.2 #84070

wants to merge 2 commits into from

Conversation

@mshustov
Copy link
Contributor

@mshustov mshustov commented Nov 23, 2020 •
edited
Loading

Summary

Backport #83899

@mshustov mshustov added the backport This PR is a backport of another PR label Nov 23, 2020
@mshustov
Copy link
Contributor Author

mshustov commented Nov 23, 2020

blocked by #83429 backport

@kibanamachine
Copy link
Contributor

kibanamachine commented Nov 23, 2020 •
edited
Loading

💔 Build Failed

Failed CI Steps

Test Failures

X-Pack Jest Tests.x-pack/plugins/index_management/__jest__/client_integration/index_template_wizard. form validation mappings (step 4) should set the correct page title

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

ReferenceError: mappingsType is not defined
    at /dev/shm/workspace/parallel/11/kibana/x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_editor.tsx:100:67
    at renderWithHooks (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:16260:18)
    at updateFunctionComponent (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:18347:20)
    at updateSimpleMemoComponent (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:18285:10)
    at updateMemoComponent (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:18188:14)
    at beginWork$1 (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:20248:16)
    at HTMLUnknownElement.callCallback (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:336:14)
    at innerInvokeEventListeners (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:315:27)
    at invokeEventListeners (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:266:3)
    at HTMLUnknownElementImpl._dispatch (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:212:11)
    at HTMLUnknownElementImpl.dispatchEvent (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:87:17)
    at HTMLUnknownElement.dispatchEvent (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:144:23)
    at Object.invokeGuardedCallbackDev (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:385:16)
    at invokeGuardedCallback (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:440:31)
    at beginWork$$1 (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:25780:7)
    at performUnitOfWork (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:24698:12)
    at workLoopSync (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:24671:22)
    at performSyncWorkOnRoot (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:24270:11)
    at /dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:12199:24
    at unstable_runWithPriority (/dev/shm/workspace/kibana/node_modules/scheduler/cjs/scheduler.development.js:697:12)
    at runWithPriority$2 (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:12149:10)
    at flushSyncCallbackQueueImpl (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:12194:7)
    at flushSyncCallbackQueue (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:12182:3)
    at scheduleUpdateOnFiber (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:23709:9)
    at setState (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:17076:5)
    at /dev/shm/workspace/parallel/11/kibana/src/plugins/es_ui_shared/public/forms/form_wizard/form_wizard_context.tsx:131:7
X-Pack Jest Tests.x-pack/plugins/index_management/__jest__/client_integration/index_template_wizard. form validation mappings (step 4) should allow the user to define document fields for a mapping

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

ReferenceError: mappingsType is not defined
    at /dev/shm/workspace/parallel/11/kibana/x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_editor.tsx:100:67
    at renderWithHooks (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:16260:18)
    at updateFunctionComponent (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:18347:20)
    at updateSimpleMemoComponent (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:18285:10)
    at updateMemoComponent (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:18188:14)
    at beginWork$1 (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:20248:16)
    at HTMLUnknownElement.callCallback (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:336:14)
    at innerInvokeEventListeners (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:315:27)
    at invokeEventListeners (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:266:3)
    at HTMLUnknownElementImpl._dispatch (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:212:11)
    at HTMLUnknownElementImpl.dispatchEvent (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:87:17)
    at HTMLUnknownElement.dispatchEvent (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:144:23)
    at Object.invokeGuardedCallbackDev (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:385:16)
    at invokeGuardedCallback (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:440:31)
    at beginWork$$1 (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:25780:7)
    at performUnitOfWork (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:24698:12)
    at workLoopSync (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:24671:22)
    at performSyncWorkOnRoot (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:24270:11)
    at /dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:12199:24
    at unstable_runWithPriority (/dev/shm/workspace/kibana/node_modules/scheduler/cjs/scheduler.development.js:697:12)
    at runWithPriority$2 (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:12149:10)
    at flushSyncCallbackQueueImpl (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:12194:7)
    at flushSyncCallbackQueue (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:12182:3)
    at scheduleUpdateOnFiber (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:23709:9)
    at setState (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:17076:5)
    at /dev/shm/workspace/parallel/11/kibana/src/plugins/es_ui_shared/public/forms/form_wizard/form_wizard_context.tsx:131:7
X-Pack Jest Tests.x-pack/plugins/index_management/__jest__/client_integration/index_template_wizard. form validation mappings (step 4) should allow the user to remove a document field from a mapping

Link to Jenkins

Standard Out

Failed Tests Reporter:
  - Test has not failed recently on tracked branches

Stack Trace

ReferenceError: mappingsType is not defined
    at /dev/shm/workspace/parallel/11/kibana/x-pack/plugins/index_management/public/application/components/mappings_editor/mappings_editor.tsx:100:67
    at renderWithHooks (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:16260:18)
    at updateFunctionComponent (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:18347:20)
    at updateSimpleMemoComponent (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:18285:10)
    at updateMemoComponent (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:18188:14)
    at beginWork$1 (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:20248:16)
    at HTMLUnknownElement.callCallback (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:336:14)
    at innerInvokeEventListeners (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:315:27)
    at invokeEventListeners (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:266:3)
    at HTMLUnknownElementImpl._dispatch (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:212:11)
    at HTMLUnknownElementImpl.dispatchEvent (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/events/EventTarget-impl.js:87:17)
    at HTMLUnknownElement.dispatchEvent (/dev/shm/workspace/kibana/node_modules/jsdom/lib/jsdom/living/generated/EventTarget.js:144:23)
    at Object.invokeGuardedCallbackDev (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:385:16)
    at invokeGuardedCallback (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:440:31)
    at beginWork$$1 (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:25780:7)
    at performUnitOfWork (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:24698:12)
    at workLoopSync (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:24671:22)
    at performSyncWorkOnRoot (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:24270:11)
    at /dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:12199:24
    at unstable_runWithPriority (/dev/shm/workspace/kibana/node_modules/scheduler/cjs/scheduler.development.js:697:12)
    at runWithPriority$2 (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:12149:10)
    at flushSyncCallbackQueueImpl (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:12194:7)
    at flushSyncCallbackQueue (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:12182:3)
    at scheduleUpdateOnFiber (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:23709:9)
    at setState (/dev/shm/workspace/kibana/node_modules/react-dom/cjs/react-dom.development.js:17076:5)
    at /dev/shm/workspace/parallel/11/kibana/src/plugins/es_ui_shared/public/forms/form_wizard/form_wizard_context.tsx:131:7

and 47 more failures, only showing the first 3.

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
indexManagement 586.8KB 586.8KB -35.0B

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

@mshustov mshustov closed this Nov 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

backport This PR is a backport of another PR

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mshustov @kibanamachine